threads / patch / 29262

patchAdd MYMETA.json to perl/.gitignore

Subject: [PATCH] Add MYMETA.json to perl/.gitignore

## tl;dr

5 messages between Dec 29, 2011 and Dec 29, 2011. Diffs are folded; open one to read it.

replies: 4people: 3as markdown or json

Jack Nagel· Dec 29, 2011, 04:42 UTC · lore

ExtUtils::MakeMaker generates MYMETA.json in addition to MYMETA.yml since version 6.57_07. As it suggests, it is just meta information about the build and is cleaned up with 'make clean', so it should be ignored.

Signed-off-by: Jack Nagel <jacknagel@gmail.com>
---
 perl/.gitignore |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
Show changes to perl/.gitignore +1 −0
diff --git a/perl/.gitignore b/perl/.gitignore
index 9235e73..d5c6e22 100644
--- a/perl/.gitignore
+++ b/perl/.gitignore
@@ -1,5 +1,6 @@
 perl.mak
 perl.mak.old
+MYMETA.json
 MYMETA.yml
 blib
 blibdirs
-- 
1.7.8.2.302.g17b4
Junio C Hamano· Dec 29, 2011, 05:34 UTC · re: Jack Nagel · lore

Re: [PATCH] Add MYMETA.json to perl/.gitignore

Jack Nagel <jacknagel@gmail.com> writes:
> ExtUtils::MakeMaker generates MYMETA.json in addition to MYMETA.yml
> since version 6.57_07. As it suggests, it is just meta information about

Are we better off ignoring MYMETA.* instead, so that we won't get affected when they start dropping new cruft with the same information in yet more different formats?

Show 18 quoted lines
> the build and is cleaned up with 'make clean', so it should be ignored.
>
> Signed-off-by: Jack Nagel <jacknagel@gmail.com>
> ---
>  perl/.gitignore |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/perl/.gitignore b/perl/.gitignore
> index 9235e73..d5c6e22 100644
> --- a/perl/.gitignore
> +++ b/perl/.gitignore
> @@ -1,5 +1,6 @@
>  perl.mak
>  perl.mak.old
> +MYMETA.json
>  MYMETA.yml
>  blib
>  blibdirs
Junio C Hamano· Dec 29, 2011, 06:58 UTC · re: Junio C Hamano · lore

Re: [PATCH] Add MYMETA.json to perl/.gitignore

Junio C Hamano <gitster@pobox.com> writes:
Show 8 quoted lines
> Jack Nagel <jacknagel@gmail.com> writes:
>
>> ExtUtils::MakeMaker generates MYMETA.json in addition to MYMETA.yml
>> since version 6.57_07. As it suggests, it is just meta information about
>
> Are we better off ignoring MYMETA.* instead, so that we won't get affected
> when they start dropping new cruft with the same information in yet more
> different formats?

Just to make sure there is no misunderstanding. The above is _not_ a rhetorical question that implies that I _think_ the patch should instead change the existing "MYMETA.yml" to "MYMETA.*" without adding a new entry to ignore "MYMETA.json". It is a pure question, and a valid answer could be "I checked with Perl people and they promise they won't be adding any more MYMETA.foo left and right with new MakeMaker releases", in which case the original patch is absolutely the right thing to do.

I am simply asking because I do not know.
Show 19 quoted lines
>
>> the build and is cleaned up with 'make clean', so it should be ignored.
>>
>> Signed-off-by: Jack Nagel <jacknagel@gmail.com>
>> ---
>>  perl/.gitignore |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/perl/.gitignore b/perl/.gitignore
>> index 9235e73..d5c6e22 100644
>> --- a/perl/.gitignore
>> +++ b/perl/.gitignore
>> @@ -1,5 +1,6 @@
>>  perl.mak
>>  perl.mak.old
>> +MYMETA.json
>>  MYMETA.yml
>>  blib
>>  blibdirs
Jack Nagel· Dec 29, 2011, 17:40 UTC · re: Ævar Arnfjörð Bjarmason · lore

Re: [PATCH] Add MYMETA.json to perl/.gitignore

On Thu, Dec 29, 2011 at 3:50 AM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 5 quoted lines
> On Thu, Dec 29, 2011 at 07:58, Junio C Hamano <gitster@pobox.com> wrote:
>> I am simply asking because I do not know.
>
> It'll stay JSON for the forseeable future. It's part of the CPAN META
> Specification.
Yep, cf. [1]. Thanks.
Jack
[1] http://search.cpan.org/~mschwern/ExtUtils-MakeMaker-6.62/lib/ExtUtils/MakeMaker.pm#Module_Meta-Data_(META_and_MYMETA)

← back to recent threads