git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC] test: Old shells and physical paths

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 20, 2012, 00:17 UTC
Message-ID
<7vmwx97f0o.fsf@alter.siamese.dyndns.org>
In-Reply-To
<CAEvUa7=sOPF9xwfGuBXv0CBZhT+79+8z3tm9ar_cz3q--kfqRQ@mail.gmail.com>
David Michael <fedora.dm0@gmail.com> writes:
Show 5 quoted lines
> In working on a port, I have to tolerate an ancient shell.  The "cd"
> and "pwd" commands don't understand the "-P" flag for physical paths,
> as some tests use.  The biggest offender is "cd -P" causing a failure
> in t/test-lib.sh (since 1bd9c64), which is sourced by every test
> script.

Is "here is a nickel, get a better shell" an option? Running tests is one thing, but I'd be worried more about scripted Porcelains broken by a non-POSIX shell if I were you.

> Would it be acceptable to instead force the platform's shell option
> (if it exists) to always use physical paths for the tests and drop the
> "-P" flags?

As a patch to the source files in my tree? Not likely, even though I cannot say for sure without looking at how the change would look like.

Previous: David MichaelNext: David Michael
Message 2 of 5 in “[RFC] test: Old shells and physical paths”
  1. David MichaelDec 19, 2012
  2. Junio C HamanoDec 20, 2012
  3. David MichaelDec 20, 2012
  4. David AguilarDec 20, 2012
  5. David MichaelDec 20, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.