Re: [PATCH] git-cvsimport.txt: cvsps-2 is deprecated

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 24, 2013, 20:58 UTC
Message-ID: <7vmwvy9u3p.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20130124201330.GT7498@serenity.lan>

John Keeping <john@keeping.me.uk> writes:

Show 22 quoted lines

> On Thu, Jan 24, 2013 at 12:04:11PM -0800, Junio C Hamano wrote:
>> John Keeping <john@keeping.me.uk> writes:
>> 
>> > git-cvsimport relies on version 2 of cvsps and does not work with the
>> > new version 3.  Since cvsps 3.x does not currently work as well as
>> > version 2 for incremental import, document this fact.
>> >
>> > Specifically, there is no way to make new git-cvsimport that supports
>> > cvsps 3.x and have a seamless transition for existing users since cvsps
>> > 3.x needs a time from which to continue importing and git-cvsimport does
>> > not save the time of the last import or import into a specific namespace
>> > so there is no safe way to calculate the time of the last import.
>> 
>> Isn't the whole "and git-cvsimport does not save the time..."  part
>> something that can be fixed in the new cvsimport that reads the
>> output from cvsps3?
>
> Yes it can be fixed there (and I have patches to do that) - my argument
> here is that there cannot be a seamless upgrade for people who are
> currently using git-cvsimport incrementally.  If you don't have that
> file then how do you create it to reflect the current state of your
> repository?

I am not disagreeing with your patch text to warn the current users that cvsimport will be made unusable if they lose cvsps2, and they are better off using other tools when doing a whole-history import.

I was trying to make sure that my understanding of the current situation and future possibilities matches yours.

Thanks, I think you clarified the situation better with your response.