git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 3/3] t9903: add extra tests for bash.showDirtyState

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 13, 2013, 19:53 UTC
Message-ID
<7vmwv86le8.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1360777065.13768.17.camel@mas>
Martin Erik Werner <martinerikwerner@gmail.com> writes:
Show 9 quoted lines
>> Strictly speaking, you have 6 not 4 combinations (shell variable
>> set/unset * config missing/set to false/set to true).  I think these
>> additional tests cover should all 6 because "config missing" case
>> should already have had tests before bash.showDirtyState was added.
>> 
>
> Indeed, I only mentioned 4 since the other ones existed already, and I
> didn't change them, but maybe it should be mentioned as "combined with
> previous tests (...) cover all 6 combinations (...)" then?

It should be sufficient to change the third line of your original to say "the config option being missing/enabled/disabled, given a dirty file." and nothing else, I think.

>> Sign-off?
>
> Ah, just forgot the -s flag on that commit, yes it should be Signed-off
> by me.
OK, I'll locally amend the patch.  Thanks.
Previous: Martin Erik WernerNext: Martin Erik Werner
Message 15 of 20 in “Add bash.showUntrackedFiles config option”
  1. 0/2 Add bash.showUntrackedFiles config optionMartin Erik Werner, Feb 12, 2013
  2. 1/2 bash completion: add bash.showUntrackedFiles optionMartin Erik Werner, Feb 12, 2013
  3. Junio C HamanoFeb 12, 2013
  4. 2/2 t9903: add test case for bash.showUntrackedFilesMartin Erik Werner, Feb 12, 2013
  5. Junio C HamanoFeb 12, 2013
  6. 0/3 Add bash.showUntrackedFiles config optionMartin Erik Werner, Feb 13, 2013
  7. 1/3 shell prompt: add bash.showUntrackedFiles optionMartin Erik Werner, Feb 13, 2013
  8. 2/3 t9903: add tests for bash.showUntrackedFilesMartin Erik Werner, Feb 13, 2013
  9. Junio C HamanoFeb 13, 2013
  10. Martin Erik WernerFeb 13, 2013
  11. Junio C HamanoFeb 13, 2013
  12. 3/3 t9903: add extra tests for bash.showDirtyStateMartin Erik Werner, Feb 13, 2013
  13. Junio C HamanoFeb 13, 2013
  14. Martin Erik WernerFeb 13, 2013
  15. Junio C HamanoFeb 13, 2013
  16. Martin Erik WernerFeb 13, 2013
  17. Junio C HamanoFeb 13, 2013
  18. 2/3 t9903: add tests for bash.showUntrackedFilesMartin Erik Werner, Feb 13, 2013
  19. 3/3 t9903: add extra tests for bash.showDirtyStateMartin Erik Werner, Feb 13, 2013
  20. Junio C HamanoFeb 13, 2013

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.