From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 13 Feb 2013 19:53:19 GMT
Subject: Re: [PATCH v2 3/3] t9903: add extra tests for bash.showDirtyState
Message-ID: <7vmwv86le8.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1360777065.13768.17.camel@mas>

Martin Erik Werner <martinerikwerner@gmail.com> writes:

>> Strictly speaking, you have 6 not 4 combinations (shell variable
>> set/unset * config missing/set to false/set to true).  I think these
>> additional tests cover should all 6 because "config missing" case
>> should already have had tests before bash.showDirtyState was added.
>> 
>
> Indeed, I only mentioned 4 since the other ones existed already, and I
> didn't change them, but maybe it should be mentioned as "combined with
> previous tests (...) cover all 6 combinations (...)" then?

It should be sufficient to change the third line of your original to
say "the config option being missing/enabled/disabled, given a dirty
file." and nothing else, I think.

>> Sign-off?
>
> Ah, just forgot the -s flag on that commit, yes it should be Signed-off
> by me.

OK, I'll locally amend the patch.  Thanks.