Re: [PATCH] remote-helpers: trivial cleanup

From: Junio C Hamano <gitster@pobox.com>
Date: May 8, 2013, 05:43 UTC
Message-ID: <7vmws6gh5y.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1367970315-5053-1-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 19 quoted lines

> The comment was copied from hg-fast-export, not used anymore.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  contrib/remote-helpers/git-remote-bzr | 1 -
>  contrib/remote-helpers/git-remote-hg  | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr
> index c19ed0e..3604c7d 100755
> --- a/contrib/remote-helpers/git-remote-bzr
> +++ b/contrib/remote-helpers/git-remote-bzr
> @@ -323,7 +323,6 @@ def export_branch(branch, name):
>          count += 1
>          if (count % 100 == 0):
>              print "progress revision %s (%d/%d)" % (revid, count, len(revs))
> -            print "#############################################################"
>  
>      repo.unlock()

THe above no longer is relevant, I think, after a39769995050 (remote-bzr: improve progress reporting, 2013-04-30). I'll apply only the hunk for remote-hg.

Show 12 quoted lines

> diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
> index 06920f2..96ad30d 100755
> --- a/contrib/remote-helpers/git-remote-hg
> +++ b/contrib/remote-helpers/git-remote-hg
> @@ -453,7 +453,6 @@ def export_ref(repo, name, kind, head):
>          count += 1
>          if (count % 100 == 0):
>              print "progress revision %d '%s' (%d/%d)" % (rev, name, count, len(revs))
> -            print "#############################################################"
>  
>      # make sure the ref is updated
>      print "reset %s/%s" % (prefix, ename)