threads / patch / 33746

patchremote-helpers: trivial cleanup

Subject: [PATCH] remote-helpers: trivial cleanup

## tl;dr

2 messages between May 7, 2013 and May 8, 2013. Diffs are folded; open one to read it.

replies: 1people: 2as markdown or json

Felipe Contreras· May 7, 2013, 23:45 UTC · lore

The comment was copied from hg-fast-export, not used anymore.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---
 contrib/remote-helpers/git-remote-bzr | 1 -
 contrib/remote-helpers/git-remote-hg  | 1 -
 2 files changed, 2 deletions(-)

Show changes to 2 files +0 −2

contrib/remote-helpers/git-remote-bzr, contrib/remote-helpers/git-remote-hg

diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr
index c19ed0e..3604c7d 100755
--- a/contrib/remote-helpers/git-remote-bzr
+++ b/contrib/remote-helpers/git-remote-bzr
@@ -323,7 +323,6 @@ def export_branch(branch, name):
         count += 1
         if (count % 100 == 0):
             print "progress revision %s (%d/%d)" % (revid, count, len(revs))
-            print "#############################################################"
 
     repo.unlock()
 
diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
index 06920f2..96ad30d 100755
--- a/contrib/remote-helpers/git-remote-hg
+++ b/contrib/remote-helpers/git-remote-hg
@@ -453,7 +453,6 @@ def export_ref(repo, name, kind, head):
         count += 1
         if (count % 100 == 0):
             print "progress revision %d '%s' (%d/%d)" % (rev, name, count, len(revs))
-            print "#############################################################"
 
     # make sure the ref is updated
     print "reset %s/%s" % (prefix, ename)

-- 
1.8.3.rc1.553.gac13664

Junio C Hamano· May 8, 2013, 05:43 UTC · re: Felipe Contreras · lore

Re: [PATCH] remote-helpers: trivial cleanup

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 19 quoted lines

> The comment was copied from hg-fast-export, not used anymore.
>
> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> ---
>  contrib/remote-helpers/git-remote-bzr | 1 -
>  contrib/remote-helpers/git-remote-hg  | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/contrib/remote-helpers/git-remote-bzr b/contrib/remote-helpers/git-remote-bzr
> index c19ed0e..3604c7d 100755
> --- a/contrib/remote-helpers/git-remote-bzr
> +++ b/contrib/remote-helpers/git-remote-bzr
> @@ -323,7 +323,6 @@ def export_branch(branch, name):
>          count += 1
>          if (count % 100 == 0):
>              print "progress revision %s (%d/%d)" % (revid, count, len(revs))
> -            print "#############################################################"
>  
>      repo.unlock()

THe above no longer is relevant, I think, after a39769995050 (remote-bzr: improve progress reporting, 2013-04-30). I'll apply only the hunk for remote-hg.

Show 12 quoted lines

> diff --git a/contrib/remote-helpers/git-remote-hg b/contrib/remote-helpers/git-remote-hg
> index 06920f2..96ad30d 100755
> --- a/contrib/remote-helpers/git-remote-hg
> +++ b/contrib/remote-helpers/git-remote-hg
> @@ -453,7 +453,6 @@ def export_ref(repo, name, kind, head):
>          count += 1
>          if (count % 100 == 0):
>              print "progress revision %d '%s' (%d/%d)" % (rev, name, count, len(revs))
> -            print "#############################################################"
>  
>      # make sure the ref is updated
>      print "reset %s/%s" % (prefix, ename)