git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: Add local time and timezone to git_print_authorship

From
Junio C Hamano <junkio@cox.net>
Date
Aug 30, 2006, 04:26 UTC
Message-ID
<7vlkp6kfwh.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<ed142v$fbi$1@sea.gmane.org>
Jakub Narebski <jnareb@gmail.com> writes:
Show 10 quoted lines
> Junio C Hamano wrote:
>
>>  (3) I'd like to eventually get rid of the abbreviated commit
>>      object name from blame output, so the setting in gitweb.css
>>      for table.blame td.age[012] (different colors and font
>>      styles) is not appropriate for what I am shooting at.
>
> What do you want to replace it with? Link can be to "commit" or "commitdiff"
> view, but some marker for commit (perhaps 'git-name-rev --tags'?) is
> needed.

I was hoping I can get away with a narrow single column of solid color that says nothing. 8 hexadecimal digits do not mean much to humans and it is taking 8-column or so of screen real estate that could otherwise be used to show the source lines instead.

I've tried doing that (just set $rev to a single space, and make the "Commit" column narrower in sub blame2 {}). One drawback is that while 8 hexadecimal digits do not mean anything they do help to match lines that came from the same rev (i.e. "I do not know what this 8fad7343 mean but this group of lines and that group are tagged together with that same 8fad7343 so they must come from the same revision").

Previous: Jakub NarebskiNext: Jakub Narebski
Message 13 of 16 in “gitweb: Additions to commitdiff view”
  1. 0/5 gitweb: Additions to commitdiff viewJakub Narebski, Aug 28, 2006
  2. 1/5 gitweb: Make git_print_log generic; git_print_simplified_log uses itJakub Narebski, Aug 28, 2006
  3. 2/5 gitweb: Do not remove signoff lines in git_print_simplified_logJakub Narebski, Aug 28, 2006
  4. 3/5 gitweb: Add author information to commitdiff viewJakub Narebski, Aug 28, 2006
  5. 4/5 gitweb: git_print_log: signoff line is non-empty lineJakub Narebski, Aug 28, 2006
  6. 5/5 gitweb: Add diff tree, with links to patches, to commitdiff viewJakub Narebski, Aug 28, 2006
  7. Linus TorvaldsAug 28, 2006
  8. gitweb: Add local time and timezone to git_print_authorshipJakub Narebski, Aug 28, 2006
  9. Junio C HamanoAug 29, 2006
  10. Jakub NarebskiAug 29, 2006
  11. Junio C HamanoAug 29, 2006
  12. Jakub NarebskiAug 29, 2006
  13. Junio C HamanoAug 30, 2006
  14. Jakub NarebskiAug 30, 2006
  15. gitweb: split output routine of blame2Junio C Hamano, Aug 29, 2006
  16. gitweb: show rev only on the first line of each group in blameJunio C Hamano, Aug 29, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.