git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/5] gitweb: git_print_log: signoff line is non-empty line

From
Jakub Narebski <jnareb@gmail.com>
Date
Aug 28, 2006, 12:48 UTC
Message-ID
<11567692953331-git-send-email-jnareb@gmail.com>
In-Reply-To
<11567692943154-git-send-email-jnareb@gmail.com>

This correct minor error in git_print_log that didn't add final empty line when requested, if commit log ended with signoff.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
 gitweb/gitweb.perl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 81d3e76..8987967 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1394,6 +1394,7 @@ sub git_print_log ($;%) {
 	foreach my $line (@$log) {
 		if ($line =~ m/^ *(signed[ \-]off[ \-]by[ :]|acked[ \-]by[ :]|cc[ :])/i) {
 			$signoff = 1;
+			$empty = 0;
 			if (! $opts{'-remove_signoff'}) {
 				print "<span class=\"signoff\">" . esc_html($line) . "</span><br/>\n";
 				next;
-- 
1.4.1.1
Previous: Jakub NarebskiNext: Jakub Narebski
Message 5 of 16 in “gitweb: Additions to commitdiff view”
  1. 0/5 gitweb: Additions to commitdiff viewJakub Narebski, Aug 28, 2006
  2. 1/5 gitweb: Make git_print_log generic; git_print_simplified_log uses itJakub Narebski, Aug 28, 2006
  3. 2/5 gitweb: Do not remove signoff lines in git_print_simplified_logJakub Narebski, Aug 28, 2006
  4. 3/5 gitweb: Add author information to commitdiff viewJakub Narebski, Aug 28, 2006
  5. 4/5 gitweb: git_print_log: signoff line is non-empty lineJakub Narebski, Aug 28, 2006
  6. 5/5 gitweb: Add diff tree, with links to patches, to commitdiff viewJakub Narebski, Aug 28, 2006
  7. Linus TorvaldsAug 28, 2006
  8. gitweb: Add local time and timezone to git_print_authorshipJakub Narebski, Aug 28, 2006
  9. Junio C HamanoAug 29, 2006
  10. Jakub NarebskiAug 29, 2006
  11. Junio C HamanoAug 29, 2006
  12. Jakub NarebskiAug 29, 2006
  13. Junio C HamanoAug 30, 2006
  14. Jakub NarebskiAug 30, 2006
  15. gitweb: split output routine of blame2Junio C Hamano, Aug 29, 2006
  16. gitweb: show rev only on the first line of each group in blameJunio C Hamano, Aug 29, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.