Re: [PATCH v2] Custom compression levels for objects and packs

From: Junio C Hamano <junkio@cox.net>
Date: May 9, 2007, 16:26 UTC
Message-ID: <7vlkfyt13i.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <alpine.LFD.0.99.0705091048120.24220@xanadu.home>

Nicolas Pitre <nico@cam.org> writes:

> So I suggest that we get rid of core.legacyheaders, preserve the legacy 
> format as the only writable loose object format and deprecate the other 
> one to keep things simpler.  Thoughts?

I agree with your analysis, especially when deeper delta chains are allowed, straight copy of loose object becomes less and less likely.

> What we need instead is a --no-reuse-object that would force 
> recompression of everything when you really want to enforce a specific 
> compression level across the whole pack(s).

Yeah. Or maybe --no-reuse to mean both and make '-f' a short-hand synonym for that.

I do not see much reason to want to tweak them independently; recomputing delta is much more expensive than recompressing anyway, and when the user says 'repack -f', it is a sign that the user is willing to spend CPU cycles.