Re: [PATCH v2] Custom compression levels for objects and packs

> On Tue, 8 May 2007, Junio C Hamano wrote:
> > Dana How <danahow@gmail.com> writes:
> > > +   /* differing core & pack compression when loose object -> must recompress */
> > > +   if (!entry->in_pack && pack_compression_level != zlib_compression_level)
> > > +           to_reuse = 0;
> > > +   else
> > I am not sure if that is worth it, as you do not know if the
> > loose object you are looking at were compressed with the current
> > settings.
> I was about to make the same comment.

> > Could we somehow remove _seen?  Perhaps by initializing the
> > _level to -1?
>
> -1 is a valid value for compression.  Actually it is equivalent to
> Z_DEFAULT_COMPRESSION.
>
> If we want the fallback logic to work, at some point we must remember if
> the current value is the default or if it is the result of an explicit
> config option.