git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: BUG: "git checkout" displays Q-escaped commit titles

From
Junio C Hamano <gitster@pobox.com>
Date
May 4, 2008, 01:54 UTC
Message-ID
<7vlk2qsukd.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20080502140536.GA3518@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> .... It seems like pp_title_line should perhaps just be checking
> for fmt == CMIT_FMT_EMAIL, but I'm not sure if that would break anything
> else,...

Yeah, your patch obviously would fix the caller, as subject and after_subject should not be given unless you are doing FMT_EMAIL. But I also think we should not even look at subject and after_subject unless fmt is CMIT_FMT_EMAIL inside pp_title_line().

Previous: Jeff KingNext: Jeff King
Message 3 of 4 in “BUG: "git checkout" displays Q-escaped commit titles”
  1. Teemu LikonenMay 2, 2008
  2. Jeff KingMay 2, 2008
  3. Junio C HamanoMay 4, 2008
  4. Jeff KingMay 4, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.