From: Junio C Hamano Date: Sun, 04 May 2008 01:54:10 GMT Subject: Re: BUG: "git checkout" displays Q-escaped commit titles Message-ID: <7vlk2qsukd.fsf@gitster.siamese.dyndns.org> In-Reply-To: <20080502140536.GA3518@sigill.intra.peff.net> Jeff King writes: > .... It seems like pp_title_line should perhaps just be checking > for fmt == CMIT_FMT_EMAIL, but I'm not sure if that would break anything > else,... Yeah, your patch obviously would fix the caller, as subject and after_subject should not be given unless you are doing FMT_EMAIL. But I also think we should not even look at subject and after_subject unless fmt is CMIT_FMT_EMAIL inside pp_title_line().