git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's in git.git (Oct 2008, #03; Tue, 14)

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 15, 2008, 19:38 UTC
Message-ID
<7vljwpr6lr.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<bsftmRx17krWBpVlulipoJEO1fWsD0hZfF3HOZcajX6GV66RKW8W6A@cipher.nrlssc.navy.mil>
Brandon Casey <casey@nrlssc.navy.mil> writes:
> Two questions:
>
>   1) Should a5a5a048 be in maint?
>      "xdiff-interface.c: strip newline (and cr) from line before pattern matching"

I would have forked a maint-fix topic to prepare a merge of this fix to both 'maint' and 'master' but apparently this was applied directly on 'master'. I may be missing a valid reason why Shawn did it this way.

If we can add a test case to demonstrate the existing breakage, I think we can (and should) cherry-pick it to 'maint'.

Show 8 quoted lines
>   2) Do we want to stick with compat/regex on
>
>       Darwin: Arjen
>      FreeBSD: Jeff
>          AIX: Mike
>
>      now that the builtin funcname patterns have been converted to Extended
>      Regular Expressions?

Mike already said AIX does not need to, and I expect others would say their native regexp library can grok ERE just fine. Let's wait for others to confirm and then remove the compat/regex thing.

Previous: Mike RalphsonNext: Shawn O. Pearce
Message 4 of 16 in “What's in git.git (Oct 2008, #03; Tue, 14)”
  1. Junio C HamanoOct 14, 2008
  2. Brandon CaseyOct 15, 2008
  3. Mike RalphsonOct 15, 2008
  4. Junio C HamanoOct 15, 2008
  5. Shawn O. PearceOct 15, 2008
  6. Junio C HamanoOct 15, 2008
  7. Shawn O. PearceOct 15, 2008
  8. 1/2 t4018-diff-funcname: rework negated last expression testdrafnel@gmail.com, Oct 16, 2008
  9. Jeff KingOct 16, 2008
  10. Brandon CaseyOct 16, 2008
  11. Pieter de BieOct 16, 2008
  12. Arjen LaarhovenOct 17, 2008
  13. Junio C HamanoOct 24, 2008
  14. Jeff KingOct 17, 2008
  15. Junio C HamanoOct 17, 2008
  16. 2/2 t4018-diff-funcname: demonstrate end of line funcname matching flawdrafnel@gmail.com, Oct 16, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.