git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/4] clone: use --progress to mean -v

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 29, 2009, 01:30 UTC
Message-ID
<7vljgmpnxj.fsf@alter.siamese.dyndns.org>
In-Reply-To
<be6fef0d0912261927p4aff3ecet5cc26bd6dfc7e1c2@mail.gmail.com>
Tay Ray Chuan <rctay89@gmail.com> writes:
Show 16 quoted lines
> On Sat, Dec 26, 2009 at 4:53 PM, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
>> On Sat, 26 Dec 2009, Tay Ray Chuan wrote:
>>
>>> This series makes git-clone follow the "argument convention" of
>>> git-pack-objects, where the option --progress is used to force reporting
>>> of reporting. This was previously done with -v/--verbose.
>>
>> No objections from my side, although you might want to advertise more that
>> this is a change in behavior.  (Meaning in the release notes)
>
> Indeed, -v/--verbose to force reporting of progress was done sometime
> last year (Thu Oct 9 2008) so there may be scripts/applications
> dependent on this option.
>
> Junio, do you have any advice on this front?

[1/4] sounds like a sane thing to do regardless of the remainder of the series, as stderr is where we write the progress output anyway. [2/4] looks trivially correct.

It is unclear what impact [3/4] has. I can read "With this patch, transport can pay attention to the verbose option given from the end user and act more verbosely, which was not something they couldn't do before", but what is the practical difference our existing users would see? IOW, which transports are silent without this patch even when the user gives -v from the command line?

And continuing the theme to separate the "verbosity" and the "progress" into two separate switches, and push them down to the transport layer by [3/4], [4/4] sounds like a logical conclusion.

I however wonder if it is of lessor impact if we only added --progress but without removing the progress from -v. Is there a downside?

Previous: Tay Ray ChuanNext: Tay Ray Chuan
Message 11 of 12 in “Add progress options”
  1. Add progress optionsBrent Goodrick, Feb 9, 2009
  2. 0/4 clone: use --progress to mean -vTay Ray Chuan, Dec 25, 2009
  3. 1/4 check stderr with isatty() instead of stdout when deciding to show progressTay Ray Chuan, Dec 25, 2009
  4. 2/4 git-clone.txt: reword description of progress behaviourTay Ray Chuan, Dec 25, 2009
  5. 3/4 clone: set transport->verbose when -v/--verbose is usedTay Ray Chuan, Dec 25, 2009
  6. 4/4 clone: use --progress to force progress reportingTay Ray Chuan, Dec 25, 2009
  7. Miklos VajnaDec 27, 2009
  8. Tay Ray ChuanDec 27, 2009
  9. Johannes SchindelinDec 26, 2009
  10. Tay Ray ChuanDec 27, 2009
  11. Junio C HamanoDec 29, 2009
  12. Tay Ray ChuanDec 29, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.