[PATCH 0/4] clone: use --progress to mean -v
- From
Tay Ray Chuan <rctay89@gmail.com>
- Date
- Dec 25, 2009, 17:12 UTC
- Message-ID
- <1261761126-5784-1-git-send-email-rctay89@gmail.com>
- In-Reply-To
- <18831.46833.862.196815@hungover.brentg.com>
This series makes git-clone follow the "argument convention" of git-pack-objects, where the option --progress is used to force reporting of reporting. This was previously done with -v/--verbose.
This in effect ensures a single consistent convention regarding progress reporting for git commands. Having two conventions may potentially confuse users.
On a related note, Brent wrote a patch a while back [1]. This series is not as ambitious his and does not deal with the main git options. In fact, only the last patch effects the titular change. If a consensus is reached on this though, I don't rule out a separate patch/series to set the convention at the main git level.
PS. If someone can enlighten me on the proper noun for the git
executable (I said "main git"), I would be very thankful.PPS. Merry Christmas and happy holidays. :)
Tay Ray Chuan (4):
check stderr with isatty() instead of stdout when deciding to show
progress
git-clone.txt: reword description of progress behaviour
clone: set transport->verbose when -v/--verbose is used
clone: use --progress to force progress reportingDocumentation/git-clone.txt | 12 +++++++++--- builtin-clone.c | 6 ++++++ t/t5702-clone-options.sh | 3 ++- transport-helper.c | 2 +- transport.c | 2 +- transport.h | 2 +- 6 files changed, 20 insertions(+), 7 deletions(-)
Footnotes: [1] http://marc.info/?l=git&m=123415527432713
-- Cheers, Ray Chuan