Re: git-format-patch should include a checksum

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 26, 2010, 23:21 UTC
Message-ID: <7vljfkxxj9.fsf@alter.siamese.dyndns.org>
In-Reply-To: <871vhcmr5b.fsf@trurl.pps.jussieu.fr>

Juliusz Chroboczek <jch@pps.jussieu.fr> writes:

Show 5 quoted lines

> I'm seeing Git patches being corrupted by mailers and still apply
> correctly.  It would be great if git-format-patch could include a hash
> of the patch body (and commit message); git-am should check the hash,
> and refuse to commit if the patch was corrupted (--force should override
> that, of course).

Do you have an example of such corrupted and incorrectly applied patches? What kind of corruption are you talking about?

format-patch/am pair is designed to be lenient, allowing people to write additional messages after the three-dash lines after the output is made but before it is given to the MUA for sending the result out, for example, so adding a checksum over the entire output and forcing a check upon application is really a bad idea, even though, provided if the patch is done cleanly, it might be acceptable as an optional feature.