Re: git-format-patch should include a checksum

From: Juliusz Chroboczek <juliusz.chroboczek@pps.jussieu.fr>
Date: Jan 27, 2010, 01:25 UTC
Message-ID: <7ir5pccp9n.fsf@lanthane.pps.jussieu.fr>
In-Reply-To: <7vljfkxxj9.fsf@alter.siamese.dyndns.org>

> Do you have an example of such corrupted and incorrectly applied patches?
> What kind of corruption are you talking about?

The commit message getting rewrapped. For some reason, the patch itself was not corrupted.

Another case is that of the commit message having its non-ASCII characters corrupted.

> adding a checksum over the entire output and forcing a check upon
> application is really a bad idea, even though, provided if the patch
> is done cleanly, it might be acceptable as an optional feature.

The part I really care about is that git-format-patch should include a checksum by default.

I'd be quite happy if git-am only warned about a checksum mismatch.

Linus:

> That wouldn't work either. People can, should, and do add extra things to 
> the message before applying it.

Shouldn't they remove the checksum line at the same time as they edit a patch?

                                        Juliusz