Re: [PATCH 2/3] builtins: utilize startup_info->help where possible
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 19, 2010, 19:10 UTC
- Message-ID
- <7vlj5uyp4x.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20101019172953.GC25139@burratino>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 7 quoted lines
> In other words, I'm not sure startup_info->help is a good abstraction.
> Maybe (modulo names) it would be better to do
>
> struct startup_info {
> ...
> const char *short_circuit; /* "-h", "--help-all", "--no-index", or NULL */
> };I am not sure short-circuit is a good abstraction either; will we have only one aspect of whatever we can short-circuit forever?