Re: [PATCH 2/3] builtins: utilize startup_info->help where possible

From: Jonathan Nieder <jrnieder@gmail.com>
Date: Oct 19, 2010, 18:50 UTC
Message-ID: <20101019185014.GG25139@burratino>
In-Reply-To: <20101019172953.GC25139@burratino>

Jonathan Nieder wrote:

> Nguyễn Thái Ngọc Duy wrote:

Show 11 quoted lines

>> It helps reduce false alarms while I'm looking for "git foo -h" code
>> path that accesses repository.
>
> Not sure I understand.  Is the idea that use of startup_info->help
> is a marker for "I've checked this code path"?
> 
> If that were the only reason, I don't think I'd like the idea.
> 
> As it is, I'm a bit conflicted: what if we decide to short-circuit
> "git foo --help-all" in the future just like we short-circuit
> "git foo -h" now?  Would that require a separate flag?

To be clear: I'm a bit conflicted but not extremely so. The help flag has the benefit of simplicity and of allowing expansion to

	git foo -h --gobbledegook

if later someone cares and a code audit shows it to be safe.