Re: [PATCH] Makefile: do not set setgid bit on directories on GNU/kFreeBSD

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 3, 2011, 19:16 UTC
Message-ID: <7vlit1ga2l.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20111003071949.GC17289@elie>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 17 quoted lines

> Jonathan Nieder wrote:
>
>> Since the setgid bit would only mean "do what you were going to do
>> already", it's better to avoid setting it.  Accordingly, ever since
>> v1.5.5-rc0~59^2 (Do not use GUID on dir in git init --share=all on
>> FreeBSD, 2008-03-05), git on true FreeBSD has done exactly that.  Set
>> DIR_HAS_BSD_GROUP_SEMANTICS in the makefile for GNU/kFreeBSD, too, so
>> machines that use glibc with the kernel of FreeBSD get the same fix.
> [...]
>> Sorry to have taken so long to send this one out.  Anyway, it seems
>> to me like the right thing to do.  Petr, what do you think?
>
> fwiw:
>
> Acked-by: Petr Salinger <Petr.Salinger@seznam.cz>
>
> Thanks for looking it over.

Sorry, this is very confusing. Are JN and PS one and the same person?