Re: [PATCH] Makefile: do not set setgid bit on directories on GNU/kFreeBSD

(people cc-ed: your input would be welcome on [*] below. See commit 81a24b52, "Do not use GUID on dir in git init --shared=all on FreeBSD" for context)

Hi Junio,

 * On some BSD systems, adding +s bit on directories is detrimental
   (it is not necessary on BSD to begin with). The installation
   procedure has been updated to take this into account.

I assume this is referring to 0b20dd8f (Makefile: do not set setgid bit on directories on GNU/kFreeBSD, 2011-10-03), which admittedly does have a subject line that suggests it would be about that (sorry about that). The change was actually about "git init -s" which sets the setgid bit on SysV-style systems to allow shared access to a repository (and can provoke errors on BSD-style systems, depending on how permissive the filesystem in use wants to be).

More to the point, the patch was just taking a fix that arrived for FreeBSD in v1.5.5 days and making it also apply to machines using an (obscure) GNU userland/FreeBSD kernel mixture.

By the way, maybe other BSD-style ports (NetBSD, OpenBSD) should be setting DIR_HAS_BSD_GROUP_SEMANTICS to get this fix, too[*]? Then the release notes could look something like this:

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
---
 Documentation/RelNotes/1.7.7.1.txt |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)