git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Allow edit of empty message with commit --amend

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 9, 2012, 19:43 UTC
Message-ID
<7vliisk9dx.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20120709185326.GF23859@arachsys.com>
Chris Webb <chris@arachsys.com> writes:
Show 13 quoted lines
> If git commit --amend is used on a commit with an empty message, it fails
> unless -m is given, whether or not --allow-empty-message is specified.
>
> Instead, allow it to proceed to the editor with an empty commit message.
> Unless --allow-empty-message is in force, it will still abort later if an
> empty message is saved from the editor. (This check was already necessary
> to prevent a non-empty commit message being edited to an empty one.)
>
> Add a test for --amend --edit of an empty commit message which fails
> without this fix, as it's a rare case that won't get frequently tested
> otherwise.
>
> Signed-off-by: Chris Webb <chris@arachsys.com>
Thanks.
Previous: Chris Webb
Message 5 of 5 in “Using git commit --amend on a commit with an empty message”
  1. Chris WebbJul 9, 2012
  2. Junio C HamanoJul 9, 2012
  3. Chris WebbJul 9, 2012
  4. Allow edit of empty message with commit --amendChris Webb, Jul 9, 2012
  5. Junio C HamanoJul 9, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.