From: Junio C Hamano <gitster@pobox.com>
Date: Mon, 09 Jul 2012 19:43:54 GMT
Subject: Re: [PATCH v2] Allow edit of empty message with commit --amend
Message-ID: <7vliisk9dx.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120709185326.GF23859@arachsys.com>

Chris Webb <chris@arachsys.com> writes:

> If git commit --amend is used on a commit with an empty message, it fails
> unless -m is given, whether or not --allow-empty-message is specified.
>
> Instead, allow it to proceed to the editor with an empty commit message.
> Unless --allow-empty-message is in force, it will still abort later if an
> empty message is saved from the editor. (This check was already necessary
> to prevent a non-empty commit message being edited to an empty one.)
>
> Add a test for --amend --edit of an empty commit message which fails
> without this fix, as it's a rare case that won't get frequently tested
> otherwise.
>
> Signed-off-by: Chris Webb <chris@arachsys.com>

Thanks.