Re: [PATCH 3/6] git-gnu-progs-Makefile: git Makefile update

From: Junio C Hamano <junkio@cox.net>
Date: Jul 11, 2005, 19:02 UTC
Message-ID: <7vk6jxupxs.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20050711101454.10318.70399.sendpatchset@bryan-larsens-ibook-g4.local>

Bryan Larsen <bryanlarsen@yahoo.com> writes:

> Update the git Makefile to put the results of config.sh into the scripts.  
> config.sh searches for gnu utilities cp, stat, date and xargs.
>
> Signed-off-by: Bryan Larsen <bryan.larsen@gmail.com>

Show 9 quoted lines

> +install: $(PROG) $(SCRIPTS) config
>  	$(INSTALL) -m755 -d $(dest)$(bin)
>  	$(INSTALL) $(PROG) $(SCRIPTS) $(dest)$(bin)
> +	. ./config ; \
> +	cd $(dest)$(bin) ; \
> +	for file in $(SCRIPTS); do \
> +		sed -e "s/DATE\=date/DATE=$${DATE}/" -e "s/CP\=cp/CP=$${CP}/" -e "s/XARGS\=xargs/XARGS=$${XARGS}/" -e "s/STAT\=stat/STAT=$${STAT}/" $$file > $$file.new; \
> +		cat $$file.new > $$file; rm $$file.new; \
> +	done

I am not yet convinced "one variable per GNU program" is the right way to do (I do agree it is a problem and I appreciate your trying to solving it; an obvious alternative cop-out would be to fix this in the user's environment, but there might be a saner solution). Assuming that this is the way to go, wouldn't it be saner if this sed munging is done in only one place, say git-sh-setup-script, and have everybody include that? If we want to have some scripts usable not at the top-level GIT directory, then git-sh-setup-script may not be a good place; in which case introduce git-sh-compat-script and have everybody include _that_ instead?