Re: [PATCH 3/6] git-gnu-progs-Makefile: git Makefile update

From: Bryan Larsen <bryanlarsen@yahoo.com>
Date: Jul 11, 2005, 21:28 UTC
Message-ID: <42D2E47E.8060602@yahoo.com>
In-Reply-To: <7vy88dqe4h.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

Show 11 quoted lines

> Junio C Hamano <junkio@cox.net> writes:
> 
> 
>>The only user of "cp -l" in the Linus GIT is git-clone-script
>>local optimization.  I could revert it to the version that I
>>originally sent to the list, which uses cpio -pld, if your cpio
>>groks that flag.
> 
> 
> Bryan, does this work for you?
>

Yes, it appears to work fine.

For the record, "${XARGS} -0r" may be uglier than "xargs -0r", but replacing it with several lines of shell magic is a loss. OTOH shell magic can be wrapped up into nice little functions. Certainly I'll appreciate being able to remove my coreutils and findutils dependency, but I think that assuming the user has gnu tools available somewhere is a reasonable assumption for tools of this type.

The tradeoff might be different for git and cogito. Cogito uses shell scripts more heavily and requires bash instead of Bourne. Certainly you've demonstrated that git can be made portable relatively cleanly. I doubt cogito will fall as easily.

But if you prefer to go this route, I'm happy with it.

Bryan