Re: [PATCH] Add -k kill keyword expansion option to git-cvsimport
- From
Junio C Hamano <junkio@cox.net>
- Date
- Aug 15, 2005, 07:12 UTC
- Message-ID
- <7vk6in65dp.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <46a038f9050814235140877be7@mail.gmail.com>
Martin Langhoff <martin.langhoff@gmail.com> writes:
Show 8 quoted lines
> [PATCH] Add -k kill keyword expansion option to git-cvsimport > > Early versions of git-cvsimport defaulted to using preexisting keyword > expansion settings. This change preserves compatibility with existing cvs > imports and allows new repository migrations to kill keyword expansion. > > Should improve our chances of detecting merges and reduce imported > repository size.
The discussion between you and Linus since you brought this up has kept me wondering if -ko is the only thing people may want to do, or sometimes -kk or even -kb or -kv make sense for some others, in which case instead of a -k option that does not allow anything but -ko, making it take an optional single letter o/k/b/v might might more sense. A single -k defaulting to -ko is fine by me if you did so, because I think that is the most useful and usual mode of operation while converting to GIT repository.
Thoughts?