git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add -k kill keyword expansion option to git-cvsimport

From
Martin Langhoff <martin.langhoff@gmail.com>
Date
Aug 15, 2005, 09:05 UTC
Message-ID
<46a038f9050815020511574e3d@mail.gmail.com>
In-Reply-To
<7vr7cv1t89.fsf@assigned-by-dhcp.cox.net>
On 8/15/05, Junio C Hamano <junkio@cox.net> wrote:
> I was just wondering if we are limiting options for people who
> want to convert their own CVS repositories by always using
> either -kkv or -ko and nothing else.

I think the other modes are relevant in different scenarios. -kv is only meaningful as file mode over the life of the file in the repo. -kk is only meaningful when calling cvs update with -j -j parameters or cvs diff, and is effectively a synonim of -ko.

In the position we are, getting file/revisions out of a repo, there are 2 possible files we can get: the one that you'll get with -kkv and the one you'll get with -ko/-kb. -kb/-ko should give us exactly the same file, modulo bugs.

I suspect that in practice -kb is more reliable when it comes to binary files. But to support that the _files() method will need to handle a slightly different protocol mode on the socket, and I rather not mess with it unless I can prove its broken. Talking with cvs servers on the socket is not my idea of fun, and there's all sorts of version-specific oddities.

cheers,
martin
Previous: Junio C HamanoNext: Martin Langhoff
Message 9 of 12 in “Add -k kill keyword expansion option to git-cvsimport”
  1. Add -k kill keyword expansion option to git-cvsimportMartin Langhoff, Aug 15, 2005
  2. Martin LanghoffAug 15, 2005
  3. Junio C HamanoAug 15, 2005
  4. Martin LanghoffAug 15, 2005
  5. Junio C HamanoAug 15, 2005
  6. Martin LanghoffAug 15, 2005
  7. Junio C HamanoAug 15, 2005
  8. Junio C HamanoAug 15, 2005
  9. Martin LanghoffAug 15, 2005
  10. Martin LanghoffAug 15, 2005
  11. Junio C HamanoAug 16, 2005
  12. Martin LanghoffAug 16, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.