Re: [PATCH] Don't send copies to the From: address

From: Junio C Hamano <junkio@cox.net>
Date: Feb 11, 2006, 03:55 UTC
Message-ID: <7vk6c2sg66.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <11396260373307-git-send-email-cbiesinger@web.de>

Christian Biesinger <cbiesinger@web.de> writes:

> Sending copies to the from address is pointless.

Ryan, care to defend this part of the code? This behaviour might have been inherited from Greg's original version.

I cannot speak for Ryan or Greg, but I think the script deliberately does this to support this workflow:

 (1) The original author sends in a patch to a subsystem
     maintainer;

 (2) The subsystem maintainer applies the patch to her tree,
     perhaps with her own sign-off and sign-offs by other people
     collected from the list.  She examines it and says this
     patch is good;

 (3) The commit is formatted and sent to higher level of the
     foodchain.  The message is CC'ed to interested parties in
     order to notify that the patch progressed in the
     foodchain.

Me, personally I do not like CC: to people on the signed-off-by list, but dropping a note to From: person makes perfect sense to me, if it is to notify the progress of the patch.

What you are after _might_ be not CC'ing it if it was your own patch. Maybe something like this would help, but even if that is the case I suspect many people want to CC herself so it needs to be an optional feature.

-- >8 -- [PATCH] Do not CC me

--- git diff

diff --git a/git-send-email.perl b/git-send-email.perl
index 3f1b3ca..a02e2f8 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -343,7 +343,7 @@ foreach my $t (@files) {
 	}
 	close F;
 
-	$cc = join(", ", unique_email_list(@cc));
+	$cc = join(", ", unique_email_list(grep { $_ ne $from } @cc));
 
 	send_message();