Re: [PATCH] Don't send copies to the From: address

From: Christian Biesinger <cbiesinger@web.de>
Date: Feb 11, 2006, 12:31 UTC
Message-ID: <43EDD911.3030003@web.de>
In-Reply-To: <7vk6c2sg66.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

> I cannot speak for Ryan or Greg, but I think the script
> deliberately does this to support this workflow:

Yeah, I suspected that this was the usecase. I don't think the patch breaks that, it just compares those addresses to $from, i.e. the address from which the email is sent.

> Me, personally I do not like CC: to people on the signed-off-by
> list, but dropping a note to From: person makes perfect sense to
> me, if it is to notify the progress of the patch.

I guess my description was a bit ambiguous, I didn't mean From: as in "author of the patch", but instead From: as in "the email header for the sender of the message", that is, the person who invokes git-send-email.

> What you are after _might_ be not CC'ing it if it was your own
> patch.  Maybe something like this would help, but even if that
> is the case I suspect many people want to CC herself so it needs
> to be an optional feature.

So a new --no-cc-self option?

> -	$cc = join(", ", unique_email_list(@cc));
> +	$cc = join(", ", unique_email_list(grep { $_ ne $from } @cc));

This seems to be basically the same as what my patch does, except that your way seems better :-)