git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Define -D__BSD_VISIBLE for FreeBSD

From
Junio C Hamano <junkio@cox.net>
Date
Dec 21, 2006, 09:26 UTC
Message-ID
<7vk60lbnvj.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<11666916581935-git-send-email-pdmef@gmx.net>
Rocco Rutte <pdmef@gmx.net> writes:
> FreeBSD (6-STABLE) "hides" many declarations (like fchmod(), IPPROTO_IPV6,
> etc.) within '#ifdef __BSD_VISIBLE' blocks. Without this flag, compilation
> will produce lots of warnings and will even fail to compile daemon.c
> since IPPROTO_IPV6 isn't available without it.

I've looked at OpenBSD header files and my impression was that the symbol __BSD_VISIBLE was pretty much internal to the implementation, and the programs are not expected to set it except by defining more public feature macros, such as _BSD_SOURCE. So I feel a bit uneasy about your approach.

We've changed this exact area quite heavily during the last 24-hours (not in Makefile but in git-compat-util.h). Do you see the problem with the latest 'master'?

Previous: Rocco RutteNext: Rocco Rutte
Message 2 of 3 in “Define -D__BSD_VISIBLE for FreeBSD”
  1. Define -D__BSD_VISIBLE for FreeBSDRocco Rutte, Dec 21, 2006
  2. Junio C HamanoDec 21, 2006
  3. Rocco RutteDec 21, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.