From: Junio C Hamano <junkio@cox.net>
Date: Thu, 21 Dec 2006 09:26:56 GMT
Subject: Re: [PATCH] Define -D__BSD_VISIBLE for FreeBSD
Message-ID: <7vk60lbnvj.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <11666916581935-git-send-email-pdmef@gmx.net>

Rocco Rutte <pdmef@gmx.net> writes:

> FreeBSD (6-STABLE) "hides" many declarations (like fchmod(), IPPROTO_IPV6,
> etc.) within '#ifdef __BSD_VISIBLE' blocks. Without this flag, compilation
> will produce lots of warnings and will even fail to compile daemon.c
> since IPPROTO_IPV6 isn't available without it.

I've looked at OpenBSD header files and my impression was that
the symbol __BSD_VISIBLE was pretty much internal to the
implementation, and the programs are not expected to set it
except by defining more public feature macros, such as
_BSD_SOURCE.  So I feel a bit uneasy about your approach.

We've changed this exact area quite heavily during the last
24-hours (not in Makefile but in git-compat-util.h).  Do you
see the problem with the latest 'master'?