git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] Teach Git how to parse standard power of 2 suffixes.

From
Junio C Hamano <junkio@cox.net>
Date
Dec 31, 2006, 02:57 UTC
Message-ID
<7vk608hiwq.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<20061231023809.GC5082@spearce.org>
Shawn Pearce <spearce@spearce.org> writes:
Show 10 quoted lines
>> Also can we fix the definition of core.packedGitWindowSize to be
>> independent of the page size on a particular platform?
>
> What do you mean?  mmap() only works in page units, and because of
> the way the code is built the minimum size we can allow is 2 pages.
>
> Asking mmap() to map less than a full page in the last page of
> a given window is silly, as that is just going to waste virtual
> address space or cause pain for the OS, depending on how that
> gets implemented.

Ah, I misread the code. I thought the value is integer that states number of pages, but you are only rounding it down and enforcing two-page minimum.

Sorry for the noise.
Previous: Shawn PearceNext: Shawn Pearce
Message 4 of 7 in “Teach Git how to parse standard power of 2 suffixes.”
  1. 1/2 Teach Git how to parse standard power of 2 suffixes.Shawn O. Pearce, Dec 31, 2006
  2. Junio C HamanoDec 31, 2006
  3. Shawn PearceDec 31, 2006
  4. Junio C HamanoDec 31, 2006
  5. Shawn PearceDec 31, 2006
  6. Junio C HamanoDec 31, 2006
  7. Shawn O. PearceDec 31, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.