From: Junio C Hamano <junkio@cox.net>
Date: Sun, 31 Dec 2006 02:57:09 GMT
Subject: Re: [PATCH 1/2] Teach Git how to parse standard power of 2 suffixes.
Message-ID: <7vk608hiwq.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20061231023809.GC5082@spearce.org>

Shawn Pearce <spearce@spearce.org> writes:

>> Also can we fix the definition of core.packedGitWindowSize to be
>> independent of the page size on a particular platform?
>
> What do you mean?  mmap() only works in page units, and because of
> the way the code is built the minimum size we can allow is 2 pages.
>
> Asking mmap() to map less than a full page in the last page of
> a given window is silly, as that is just going to waste virtual
> address space or cause pain for the OS, depending on how that
> gets implemented.

Ah, I misread the code.  I thought the value is integer that
states number of pages, but you are only rounding it down and
enforcing two-page minimum.

Sorry for the noise.