git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Fix set_work_tree on cygwin

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 2, 2007, 21:43 UTC
Message-ID
<7vk5sdtxx0.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<Pine.LNX.4.64.0708022230070.14781@racer.site>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 6 quoted lines
>> Static is supposed to be zeroed and also is supposed to retain
>> the value from the previous call.  I am guessing from the change
>> to make "rel" to non-static that this function is called twice
>> perhaps?
>
> Apparently (but I would feel safer with strlcpy() anyway)...
Yup, send an appliable "final" version, somebody please?
> ...  git-read-tree 
> is the first and only offender which comes up in the test suite:
It is unclear.

Is this an optimization, or enforcing the new world order? IOW, is it now banned to call setup twice?

Previous: Johannes SchindelinNext: Johannes Schindelin
Message 7 of 9 in “Fix set_work_tree on cygwin”
  1. Fix set_work_tree on cygwinAlex Riesen, Aug 2, 2007
  2. Johannes SchindelinAug 2, 2007
  3. Alex RiesenAug 2, 2007
  4. Johannes SchindelinAug 2, 2007
  5. Junio C HamanoAug 2, 2007
  6. Johannes SchindelinAug 2, 2007
  7. Junio C HamanoAug 2, 2007
  8. Allow setup_work_tree() to be called several timesJohannes Schindelin, Aug 2, 2007
  9. Fix unterminated string copy in set_work_treeAlex Riesen, Aug 2, 2007

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.