From: Junio C Hamano Date: Thu, 02 Aug 2007 21:43:39 GMT Subject: Re: [PATCH] Fix set_work_tree on cygwin Message-ID: <7vk5sdtxx0.fsf@assigned-by-dhcp.cox.net> In-Reply-To: Johannes Schindelin writes: >> Static is supposed to be zeroed and also is supposed to retain >> the value from the previous call. I am guessing from the change >> to make "rel" to non-static that this function is called twice >> perhaps? > > Apparently (but I would feel safer with strlcpy() anyway)... Yup, send an appliable "final" version, somebody please? > ... git-read-tree > is the first and only offender which comes up in the test suite: It is unclear. Is this an optimization, or enforcing the new world order? IOW, is it now banned to call setup twice?