Re: [PATCH] Don't use GIT_CONFIG in t5505-remote

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 27, 2008, 08:16 UTC
Message-ID: <7vk5kqx18u.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20080226221959.GB6098@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 13 quoted lines

> On Tue, Feb 26, 2008 at 05:15:31PM -0500, Daniel Barkalow wrote:
>
>> For some reason, t5505-remote was setting GIT_CONFIG to .git/config
>> and exporting it. The sole effect of this was to cause the tests to
>> fail if "git clone" obeyed it (which it presumably should).
>> 
>> Signed-off-by: Daniel Barkalow <barkalow@iabervon.org>
>> ---
>> Maybe test-lib used to set GIT_CONFIG to something that would interfere? 
>> Or the default behavior was wrong?
>
> test-lib used to set it to ".git/config" until recently, so this would
> have been a no-op. As to why it was ever in here, I have no idea.

Right.