git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Don't use GIT_CONFIG in t5505-remote

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 27, 2008, 08:21 UTC
Message-ID
<7vd4qix11i.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<alpine.LNX.1.00.0802261713520.19665@iabervon.org>
Daniel Barkalow <barkalow@iabervon.org> writes:
> For some reason, t5505-remote was setting GIT_CONFIG to .git/config
> and exporting it. The sole effect of this was to cause the tests to
> fail if "git clone" obeyed it (which it presumably should).

Your patch is correct, as it was a no-op to set and export GIT_CONFIG to .git/config there as Jeff pointed out.

But I think git-clone should explicitly ignore user-supplied GIT_CONFIG in the environment if exists, when it wants to update the configuration file for the new repository it created, as I mentioned in the other message.

And I think scripted version has the same issue. It would update random places GIT_CONFIG points at, when it wants to modify the configuration file for the new repository it just built, which would be a bug.

Previous: Junio C Hamano
Message 4 of 4 in “Don't use GIT_CONFIG in t5505-remote”
  1. Don't use GIT_CONFIG in t5505-remoteDaniel Barkalow, Feb 26, 2008
  2. Jeff KingFeb 26, 2008
  3. Junio C HamanoFeb 27, 2008
  4. Junio C HamanoFeb 27, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.