Re: [PATCH] Fix problem with authentification on http repository.
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 10, 2008, 07:32 UTC
- Message-ID
- <7vk5fuqjn8.fsf@gitster.siamese.dyndns.org>
- In-Reply-To
- <20080710072420.GA5167@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 11 quoted lines
> On Wed, Jul 09, 2008 at 01:43:07PM +0200, Johannes Schindelin wrote: > >> > Note that http://user:pass@server/path/ /should/ work (but that would >> > need validation), though not a good idea on command line. >> >> Well, now that the programs using URLs are all builtins, we can actually >> do something about it. We can edit out the "user[:pass]@" part out of >> argv, which usually means that "ps" will not see it anymore. > > Wouldn't there still be a race condition for publicly broadcasting your > password via ps?
In addition, I think on some Unices overwriting argv[0] does not have the effect Dscho is aiming for.
I thought we do discourage [:pass] part in our documentation.