Re: [PATCH] Fix problem with authentification on http repository.

From: Mike Hommey <mh@glandium.org>
Date: Jul 9, 2008, 08:56 UTC
Message-ID: <20080709085651.GA23453@glandium.org>
In-Reply-To: <7vhcazlbch.fsf@gitster.siamese.dyndns.org>

On Wed, Jul 09, 2008 at 01:18:22AM -0700, Junio C Hamano <gitster@pobox.com> wrote:

Show 20 quoted lines

> Mike Hommey <mh@glandium.org> writes:
> 
> > On Tue, Jul 08, 2008 at 11:28:15PM -0700, Junio C Hamano <gitster@pobox.com> wrote:
> > ...
> >> >> Actually Documentation/howto/setup-git-server-over-http.txt
> >> >> talks about http://user@server/path/ format.  How well does this
> >> >> work in practice?  If it does, we should update Documentation/urls.txt
> >> >> to allow optional user@ there like...
> >> >
> >> > AFAIK, there is nothing to deal with asking a password to the user in git
> >> > in this case, so that doesn't work.
> >> 
> >> Then perhaps the howto needs updating?
> >
> > Actually, the howto tells to setup a ~/.netrc file, which should make
> > the http://user@server/path/ format work. I don't know if dropping user@
> > would still work, that depends how libcurl works with it.
> 
> Ok, so the documentation update I suggested earlier may actually be
> valid, right?

The problem is that these urls won't work out of the box if the user doesn't setup a .netrc file. I'd say it would be better not to add these forms in Documentation/urls.txt until git prompts for the password when it is missing.

Note that http://user:pass@server/path/ /should/ work (but that would need validation), though not a good idea on command line.

Mike