Re: Reverting an uncommitted revert

From: Junio C Hamano <gitster@pobox.com>
Date: May 21, 2009, 06:16 UTC
Message-ID: <7vk54bc766.fsf@alter.siamese.dyndns.org>
In-Reply-To: <alpine.LFD.2.00.0905201406280.3906@xanadu.home>

Nicolas Pitre <nico@cam.org> writes:

Show 8 quoted lines

>>  (1) When would you "auto" write-tree?  When you do "git add" or anything
>>      that adds new contents to the index?  Or immediately before you do
>>      something destructive like "git reset"?  Or perhaps both?
>
> Delaying any IO until it is clear that something is to be discarded is 
> the best approach performance wise.  So perhaps not on the first 'git 
> add' but certainly on the second one with an already cached path for 
> which new (different) content is going to replace previous content.

I hope that you are not forgetting that it costs cycles to determine "it is clear that something is to be discarded".

The "diff-index --cached" optimization I did today may help, as it would allow you to check with the last trash-log more cheaply, but it certainly is not free.