Re: [PATCH] rev-list: heed --abbrev-commit option

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 26, 2010, 19:32 UTC
Message-ID: <7vk4sylvzj.fsf@alter.siamese.dyndns.org>
In-Reply-To: <b1b0f22cf3dc6d67f6094e761a1b7402b1471e97.1269264868.git.git@drmicha.warpmail.net>

Michael J Gruber <git@drmicha.warpmail.net> writes:

> Currently, rev-list has a default of "0" for abbrev which means that
> switching on abbreviations with --abbrev-commit has no visible effect,
> even though the option is documented.

Hmm, I actually think this was deliberate. rev-list is designed to be a low level machinery for getting full object names, and in that context, setting the default abbreviation length to "don't abbreviate" gave us some safety, with additional safety of requiring a separate --abbrev-commit option to affect the main "show the commit object names" codepath (the latter of which would not likely to change). The caller sets explicitly how long an output it wants (see git-rebase--interactive for an example).

Having said that, I don't think this would break existing scripts, so let's queue it and see what happens.