Re: git rev-list formatting
- From
Erik Faye-Lund <kusmabite@googlemail.com>
- Date
- Mar 23, 2010, 12:40 UTC
- Message-ID
- <40aa078e1003230540o40f551b2re8fbf1e70ae9ddbe@mail.gmail.com>
- In-Reply-To
- <20100323122603.GA2053@coredump.intra.peff.net>
On Tue, Mar 23, 2010 at 1:26 PM, Jeff King <peff@peff.net> wrote:
Show 21 quoted lines
> On Tue, Mar 23, 2010 at 07:06:38AM -0400, Eli Barzilay wrote: > >> > [...] >> >> I've made a copy of the repository at >> >> http://tmp.barzilay.org/testing.git.tgz >> >> which shows what I said when I run >> >> git rev-list --pretty="%b" 267d60518 >> git rev-list --pretty="%b" 84482 > > The problem is that most of those commits don't _have_ bodies. Remember > that "%b" is about everything in the commit message after the first > first paragraph. > > Now one might argue that rev-list should still put in the extra newline > separator in this case. I haven't been paying attention, but hasn't that > been discussed in another thread recently? >
If you're thinking of the stuff I've been working on, that's about multiple commits ending up at the same line with --pretty=oneline, and not _really_ about unconditionally adding that new-line. But it is closely related, and it looks like it's the same code that is responsible for the current behavior. Commit 55246aa is what made then new-line conditional in the first place.
-- Erik "kusma" Faye-Lund