Re: [PATCH] diff: fix textconv error zombies

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 30, 2010, 21:46 UTC
Message-ID: <7vk4stv5y5.fsf@alter.siamese.dyndns.org>
In-Reply-To: <201003301936.03394.j6t@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

> Thanks for your work, but I'm worried that in your version the close()
> call is not before the finish_command (but that's really not _that_
> important in this case).

Are you referring to this part in api-run-command.txt?

    This describes the arguments, redirections, and environment of a
    command to run in a sub-process.

    The caller:

    1. allocates and clears (memset(&chld, 0, sizeof(chld));) a
       struct child_process variable;
    2. initializes the members;
    3. calls start_command();
    4. processes the data;
    5. closes file descriptors (if necessary; see below);
    6. calls finish_command().

In "if necessary; see below", I tried to find something to help me judge why you said "That's really not _that_ important in this case", but I think I failed. Perhaps we would want a bit more detailed discussion in the document there?

The patch looks fine.  Thanks; will queue this one.