Re: [PATCH 0/3] fast textconv

From: Jeff King <peff@peff.net>
Date: Mar 30, 2010, 16:04 UTC
Message-ID: <20100330160449.GB17763@coredump.intra.peff.net>
In-Reply-To: <fabb9a1e1003281113o4cb1e723p4ed39521b645fffe@mail.gmail.com>

On Sun, Mar 28, 2010 at 12:13:10PM -0600, Sverre Rabbelier wrote:

Show 10 quoted lines

> On Sun, Mar 28, 2010 at 11:34, Jeff King <peff@peff.net> wrote:
> > Here is a quick and dirty in-core implementation. The most notable
> > defect is that all textconvs store under refs/notes/textconv, which is
> > obviously bogus if you might textconv the same blob in two different
> > ways.
> 
> What I did for the implementation of remote helpers is hash the url of
> the remote when storing it locally, that way you don't have to worry
> about escaping urls etc. You could do the same with the textconvs,
> store it under  refs/notes/textconv/<hash of textconv filter>?

I thought about something like that, but we want to keep something that is comprehensible to the user. If my install of "exif" changes, I need to be able to say "invalidate the cache for exif". If it's human-readable, I know I need to clear refs/notes/textconv/exif. But if it's a hash, then I need a special tool to figure out which ref is relevant.

Instead, my plan is to use refs/notes/textconv/$TYPE, where $TYPE is the same string used by the config (e.g., "diff.$TYPE.textconv") and the gitattributes file (e.g., "*.jpg diff=$TYPE"). The user has already provided us a with a short, unique, meaningful name.

-Peff