Re: [BUG] git rev-list --no-walk A B C sorts by commit date incorrectly

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 8, 2011, 05:41 UTC
Message-ID: <7vk4ig7y0t.fsf@alter.siamese.dyndns.org>
In-Reply-To: <BB84A2F6-E6B0-49E4-9DC7-6BA8860623E6@sb.org>

Kevin Ballard <kevin@sb.org> writes:

> It almost works, but not quite. My inclination is to say
> `git rev-list --no-walk A B C` should emit A B C in that order. Implemented
> this way, `git rev-list --no-walk ^HEAD~3 HEAD` emits commits in the wrong
> order,

"git rev-list --no-walk ^HEAD~3 HEAD"? Isn't it a nonsense? If it is "no walk", then why do you even list a negative one?

As to cherry-pick, I wouldn't be surprised if it relies on the current internal working of pushing commits in the date order to the queue regardless of how they were given from the command line.

Indeed, it does exactly that, and then tries to compensate it---notice that builtin/revert.c:prepare_revs() gives "revs->reverse" to it. That also needs to be fixed.