git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [BUG] git rev-list --no-walk A B C sorts by commit date incorrectly

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 9, 2011, 06:58 UTC
Message-ID
<7vaaja8sxd.fsf@alter.siamese.dyndns.org>
In-Reply-To
<7vk4ig7y0t.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
> "git rev-list --no-walk ^HEAD~3 HEAD"?  Isn't it a nonsense?  If it is "no
> walk", then why do you even list a negative one?
The above was my thinko.

When you explicitly give range to no-walk, you override that no-walk with "please walk". This is primarily to help Linus who wanted to do "git show HEAD~3..HEAD"---see how his thinking changed over time by comparing aa27e461 and f222abde.

The right fix then would be to first always add in the order things were given, and sort by date at the end after adding everything to queue and we still have no_walk set, or something like that.

Previous: Kevin BallardNext: Martin von Zweigbergk
Message 6 of 7 in “[BUG] git rev-list --no-walk A B C sorts by commit date incorrectly”
  1. Kevin BallardJan 8, 2011
  2. Junio C HamanoJan 8, 2011
  3. Kevin BallardJan 8, 2011
  4. Junio C HamanoJan 8, 2011
  5. Kevin BallardJan 8, 2011
  6. Junio C HamanoJan 9, 2011
  7. Martin von ZweigbergkJan 12, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.