Re: [PATCH 0/2] git-p4: fix clone @all regression

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 13, 2011, 19:54 UTC
Message-ID: <7vk4g2hk3u.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20110312162246.GA8509@arf.padd.com>

Pete Wyckoff <pw@padd.com> writes:

Show 13 quoted lines

> My commit e32e00dc88948a730b8b1f3b8129f30c313713e7
> "git-p4: better message for "git-p4 sync" when not cloned"
> broke clone @all.  This fixes it per Tor Arvid's patch
> and adds a test to make sure it doesn't happen again.
>
>     git-p4: fix clone @all regression
>     git-p4: test clone @all
>
>  contrib/fast-import/git-p4 |    2 +-
>  t/t9800-git-p4.sh          |   16 ++++++++++++++++
>  2 files changed, 17 insertions(+), 1 deletions(-)
>
> Please queue to maint.  Thanks,

The buggy e32e00d itself is not in maint, even though the branch it is on whose tip is at 3820007 (git-p4: support clone --bare, 2011-02-19) could be merged to maint if we really wanted to. But it doesn't look like that the changes on the branch are all fixes, so it is not entirely clear if we want to.

In any case, will merge the result of applying these two on top of 3820007 (git-p4: support clone --bare, 2011-02-19) to master.

Thanks.