git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 1/2] git-p4: fix clone @all regression

From
PWPete Wyckoff <pw@padd.com>
Date
Mar 12, 2011, 16:23 UTC
Message-ID
<20110312162323.GB8509@arf.padd.com>
In-Reply-To
<20110312162246.GA8509@arf.padd.com>

Commit e32e00dc88948a730b8b1f3b8129f30c313713e7 "git-p4: better message for "git-p4 sync" when not cloned" broke the use of the "@all" revision specifier, e.g., "git-p4 clone //depot/xxx@all".

Fix it as per Tor Arvid's quick patch.
Signed-off-by: Pete Wyckoff <pw@padd.com>
Reported-by: Anatol Pomozov <anatol.pomozov@gmail.com>
Based-on-patch-by: Tor Arvid Lund <torarvid@gmail.com>
---
 contrib/fast-import/git-p4 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/contrib/fast-import/git-p4 b/contrib/fast-import/git-p4
index 2df3bb2..7cb479c 100755
--- a/contrib/fast-import/git-p4
+++ b/contrib/fast-import/git-p4
@@ -1763,7 +1763,7 @@ class P4Sync(Command):
 
                 changes.sort()
             else:
-                if not self.p4BranchesInGit:
+                if not isinstance(self, P4Clone) and not self.p4BranchesInGit:
                     die("No remote p4 branches.  Perhaps you never did \"git p4 clone\" in here.");
                 if self.verbose:
                     print "Getting p4 changes for %s...%s" % (', '.join(self.depotPaths),
-- 
1.7.4.1
Previous: Pete WyckoffNext: Pete Wyckoff
Message 2 of 4 in “git-p4: fix clone @all regression”
  1. 0/2 git-p4: fix clone @all regressionPete Wyckoff, Mar 12, 2011
  2. 1/2 git-p4: fix clone @all regressionPete Wyckoff, Mar 12, 2011
  3. 2/2 git-p4: test clone @allPete Wyckoff, Mar 12, 2011
  4. Junio C HamanoMar 13, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.