git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: GSOC idea: build in scripts and cleanups

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 7, 2011, 22:19 UTC
Message-ID
<7vk4f5emcm.fsf@alter.siamese.dyndns.org>
In-Reply-To
<201104071530.19566.robert.david.public@gmail.com>
Robert David <robert.david.public@gmail.com> writes:
> This task also include cleaning the functionality of this code, to make these 
> functions more "standardized". 
> This means consolidate the differences in these functions and make them more 
> consistent in the user point of view.

Standardized, consolidate, consistent are all pretty words but at the same time they are highly subjective. Even though you may not have to have the detailed description of everything in the proposal, you would need to at least have a handful of examples of what are wrong with the current code in mind when making such a sweeping statement, but I cannot sense that from this proposal.

While reading the current add-i code recently, I noticed that over time the code quality deteriorated compared to the reasonably clean design in the original version, perhaps due to excessive copying and mimicing, especially when "Edit patch" feature was added and then more recently when new modes to apply patches in different directions are added to allow other commands like "git reset" and "git checkout" to implement their "--patch" options.

An example of a clean-up in the right direction may be a patch I posted a few days ago:

  http://thread.gmane.org/gmane.comp.version-control.git/170685/focus=171017 
Is that the kind of "consolidation" you have in mind?

Also I am a bit puzzled by the inconsistency between the various stages of your goals. A clearly stated primary goal is:

> Main and final project goal is integrating fully git-add--interactive into 
> current git-add code.
but the success criteria is only about the above "This task also include"?
Previous: Robert DavidNext: Robert David
Message 17 of 20 in “GSOC idea: build in scripts and cleanups”
  1. Robert DavidMar 26, 2011
  2. Jonathan NiederMar 26, 2011
  3. Jeff KingMar 26, 2011
  4. Robert DavidMar 28, 2011
  5. Jeff KingMar 28, 2011
  6. Thomas RastMar 30, 2011
  7. Robert DavidMar 30, 2011
  8. Robert DavidApr 3, 2011
  9. Robert DavidApr 4, 2011
  10. Junio C HamanoApr 4, 2011
  11. Robert DavidApr 4, 2011
  12. Jeff KingApr 5, 2011
  13. Junio C HamanoApr 5, 2011
  14. Jeff KingApr 5, 2011
  15. Robert DavidApr 5, 2011
  16. Robert DavidApr 7, 2011
  17. Junio C HamanoApr 7, 2011
  18. Robert DavidApr 8, 2011
  19. Jonathan NiederApr 11, 2011
  20. Robert DavidApr 17, 2011

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.